Update styles to support using attributes for timeline elements#36
Open
walterg2 wants to merge 2 commits intorpocklin:masterfrom
walterg2:style-fixes
Open
Update styles to support using attributes for timeline elements#36walterg2 wants to merge 2 commits intorpocklin:masterfrom walterg2:style-fixes
walterg2 wants to merge 2 commits intorpocklin:masterfrom
walterg2:style-fixes
Conversation
Author
|
Hey @rpocklin: Sorry for the long delay in getting back to this... kids and work got extremely busy over the summer. I've made the fixes you asked for and updated everything to align with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the style sheet in place has a few places where it is looking for the timeline-* tags instead of relying on CSS classes. This causes users that want to keep their HTML valid issues as they need to duplicate the styles for angular-timeline.
Changes
imgstyle to be nested inside the timeline class so it would not collide with other styles set up by the userNotes
Please let me know if you'd like any changes to what I've done here.